SethFalco commented on a change in pull request #93:
URL: https://github.com/apache/commons-beanutils/pull/93#discussion_r675191160
##########
File path: pom.xml
##########
@@ -344,12 +344,24 @@
<version>3.2.1</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.7.2</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
Review comment:
Oh, I thought we'd have to keep the JUnit 4 dependency until all tests
were migrated to JUnit 5.
I guess `junit-vintage-engine` doesn't require that.
At least that's the impression the docs gave me.
> The JUnit Platform can run JUnit 4 based tests as long as you configure a
testImplementation dependency on JUnit 4 and a testRuntimeOnly dependency on
the JUnit Vintage TestEngine implementation similar to the following.
>
> ```gradle
> dependencies {
> testImplementation("junit:junit:4.13")
> testRuntimeOnly("org.junit.vintage:junit-vintage-engine:5.7.2")
> }
> ```
> \-
https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle-engines-configure
Just tried now and it worked perfectly fine without the JUnit 4 dependency,
though. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
