[ 
https://issues.apache.org/jira/browse/LANG-1665?focusedWorklogId=626653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626653
 ]

ASF GitHub Bot logged work on LANG-1665:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/21 13:21
            Start Date: 22/Jul/21 13:21
    Worklog Time Spent: 10m 
      Work Description: aherbert commented on pull request #780:
URL: https://github.com/apache/commons-lang/pull/780#issuecomment-884907417


   This issue is related to the BigDecimal equals method only returning true to 
binary equality. The same issue arises for Double or Float where there are two 
representations of zero:
   ```java
   Double d1 = Double.valueOf(-0.0);
   Double d2 = Double.valueOf(0.0);
   assert d1.equals(d2) == false;
   Float f1 = Float.valueOf(-0.0f);
   Float f2 = Float.valueOf(0.0f);
   assert f1.equals(f2) == false;
   ```
   I am not aware of other objects that can have a comparison that is 0 but not 
be equal. This applies to Numbers. I would suggest expanding the method to 
cover these cases of numbers:
   ```java
   public static boolean equalsOrCompareNumber(final Object object1, final 
Object object2);
   ```
   
   I have put an initial implementation on the Jira ticket. The details should 
be discussed there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 626653)
    Time Spent: 20m  (was: 10m)

> Modify Tuple equals to take BigDecimal comparison
> -------------------------------------------------
>
>                 Key: LANG-1665
>                 URL: https://issues.apache.org/jira/browse/LANG-1665
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.tuple.*
>    Affects Versions: 3.12.0
>            Reporter: Chikashi Toyoshima
>            Priority: Trivial
>             Fix For: 3.12.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I understand that this would be a bit controversial. Imhp as possibly 
> ignorable suggestion, it'd be more helpful if the Tuple supports BgDecimal 
> numeric equality rather than simply checking object.
>  
> In a particular case, you may want to check if a collection of pairs contain 
> a certain pair which includes BigDecimal values. Then to check object 
> equality is maybe just right or not. But in many cases, I assume that numeric 
> comparison would be more demanded such as following simple example. 
> {code:java}
> Set<Pair<String, BigDecimal>> someCollection = getPairs(); 
> someCollection.contains(Pair.of("foo", BigDecimal.valueOf(100))); 
> {code}
>  
> I created the PR. Please take a look. I'm happy to whichever it is accepted 
> or not receiving feedback.
> [https://github.com/apache/commons-lang/pull/780]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to