[
https://issues.apache.org/jira/browse/LANG-1665?focusedWorklogId=626928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626928
]
ASF GitHub Bot logged work on LANG-1665:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 22:51
Start Date: 22/Jul/21 22:51
Worklog Time Spent: 10m
Work Description: toyopilgrim commented on pull request #780:
URL: https://github.com/apache/commons-lang/pull/780#issuecomment-885285815
@garydgregory @aherbert
Thank you guys for the feedback. I'm convinced of all the discussions above.
>This issue suggests the need for a custom set of Number subclasses with a
policy enum that dictates what kind of equality you want. But such a class
belongs in Commons Numbers/Math, not Lang.
This kind of feedback is exactly what I wanted. An intention of that
ignorable PR is to receive a point of view like if there's a right place for
it. Do you think that it'd be worth adding such a class in a right package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 626928)
Time Spent: 1h (was: 50m)
> Modify Tuple equals to take BigDecimal comparison
> -------------------------------------------------
>
> Key: LANG-1665
> URL: https://issues.apache.org/jira/browse/LANG-1665
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.tuple.*
> Affects Versions: 3.12.0
> Reporter: Chikashi Toyoshima
> Priority: Trivial
> Fix For: 3.12.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I understand that this would be a bit controversial. Imhp as possibly
> ignorable suggestion, it'd be more helpful if the Tuple supports BgDecimal
> numeric equality rather than simply checking object.
>
> In a particular case, you may want to check if a collection of pairs contain
> a certain pair which includes BigDecimal values. Then to check object
> equality is maybe just right or not. But in many cases, I assume that numeric
> comparison would be more demanded such as following simple example.
> {code:java}
> Set<Pair<String, BigDecimal>> someCollection = getPairs();
> someCollection.contains(Pair.of("foo", BigDecimal.valueOf(100)));
> {code}
>
> I created the PR. Please take a look. I'm happy to whichever it is accepted
> or not receiving feedback.
> [https://github.com/apache/commons-lang/pull/780]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)