kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-885937083
@ali-ghanbari >But if we want to keep Algorithm C, we must keep Algorithm B as it is being called from Algorithm C. And in that case (in my opinion) it is ideal to use Algorithm B for apply method, because we already have the implementation and it involves less computation than Algorithm C. You convinced me that the current approach of Algorithm B + Algorithm C is the best option :-), I missed the part that C was using B, sorry! And thanks for understanding and pointing it so politely. >I happened to learn about this more efficient algorithm in a research project where I was getting OutOfMemoryError with the current implementation of apply method and I used this new implementation and it worked without any problem. Interesting! I think JMH should be able to show that the new code performs better memory-wise too. @ali-ghanbari I will finish reading the paper either this weekend or next week, sync your branch once more, and then go one last time through the code. If I don't find anything missing, except for the missing JMH test (which I could try to help if you don't have time, it's been ages since I wrote a JMH benchmark, good to practice) it should be ready to be approved! Thanks a lot. Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
