tvand commented on a change in pull request #71:
URL: https://github.com/apache/commons-jcs/pull/71#discussion_r705425201



##########
File path: 
commons-jcs-core/src/main/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/mysql/MySQLDiskCacheFactory.java
##########
@@ -102,11 +102,8 @@ protected void scheduleOptimizations( final 
MySQLDiskCacheAttributes attributes,
                 try
                 {
                     final Date[] dates = 
ScheduleParser.createDatesForSchedule( attributes.getOptimizationSchedule() );

Review comment:
       Would you please consider documenting "never null" as the return value 
of ScheduleParser.createDatesForSchedule()? The same goes for other calls.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to