rmannibucau commented on a change in pull request #71:
URL: https://github.com/apache/commons-jcs/pull/71#discussion_r705426326
##########
File path:
commons-jcs-jcache/src/main/java/org/apache/commons/jcs3/jcache/JCSCachingManager.java
##########
@@ -189,8 +189,8 @@ private void assertNotClosed()
assertNotClosed();
assertNotNull(cacheName, "cacheName");
assertNotNull(configuration, "configuration");
- final Class<?> keyType = configuration == null ? Object.class :
configuration.getKeyType();
Review comment:
didnt check them all but this one was a typo configuration should check
configuration.getKeyType() (resp value) to default to Object so instead of
dropping it I would fix it, wdyt?
##########
File path:
commons-jcs-jcache/src/main/java/org/apache/commons/jcs3/jcache/cdi/CacheResolverFactoryImpl.java
##########
@@ -50,7 +50,7 @@ public CacheResolver getCacheResolver(final
CacheMethodDetails<? extends Annotat
public CacheResolver getExceptionCacheResolver(final
CacheMethodDetails<CacheResult> cacheMethodDetails)
{
final String exceptionCacheName =
cacheMethodDetails.getCacheAnnotation().exceptionCacheName();
- if (exceptionCacheName == null || exceptionCacheName.isEmpty())
+ if (exceptionCacheName.isEmpty())
Review comment:
this is likely a false positive, can be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
