[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=676976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676976
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/21 10:57
Start Date: 05/Nov/21 10:57
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961799086
@darkma773r I've been thinking the types we use in that class, like
`ImageParser`, `ImagingParameter`, and `ImageFormat`. When we pass the
arguments to `writeImage`, for example, it includes a `ImageFormat`, and also
an `ImagingParameters`.
However, when you pass an `ImageFormats.GIF` it's obvious the parameter will
be of type `GifImagingParameters`. It is also obvious the parser will be the
`GifImageParser`.
I'm thinking that maybe we could use something like `ImagingParameters<Gif>`
and `ImageParser<Gif>`, eliminating the `ImageFormat`. I think it would be
possible to have a map of format=>parser, and a method that retrieves the
parser with the right format. Sorry if it's vague, I will think more about it
this weekend and see if I can suggest some code to compare with what we have 👍
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 676976)
Time Spent: 13.5h (was: 13h 20m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
