[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=677170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-677170
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/21 19:18
Start Date: 05/Nov/21 19:18
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961784862
My perspective is limited because I am so focused on TIFFs. And I seldom use
the basic Imaging class (preferring the TIFF-specific parser and write
classes). So I am sure I am unaware of a number of valid use cases.
That being said, I might think that simpler is better. The Imaging class
API could be cut back to just include only limited support for parameters. The
read-related operations might not even take parameters arguments. The
write-related would only take a very basic parameters. In fact, except for a
"dots per inch" or "mm per pixel" setting, I can't think of anything that would
be supported across the majority of write operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 677170)
Time Spent: 13h 40m (was: 13.5h)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
