Cp-John commented on pull request #116: URL: https://github.com/apache/commons-pool/pull/116#issuecomment-971231217
> Looks harmless and, as @psteitz pointed out, looks like it will improve performance for some pools. Created placeholder issue, and looked at coverage. > >  > > Even though it shows the line as covered, I believe not all branches of the condition statement are covered. Not sure if it'd be easy to add a unit test for when `getBlockWhenExhausted()` is `true` and when it's `false` (maybe to avoid regressions)? > > Thanks Bruno Hi Bruno! Thanks for your prompt response. I have added two unit tests for when `getBlockWhenExhausted()` is `true` and when it's `false`. Cheers, Cao Peng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
