garydgregory commented on pull request #116: URL: https://github.com/apache/commons-pool/pull/116#issuecomment-980508876
Hi All. I do not think this PR is ready yet because the tests pass when the `main` changes are _not_ applied. The new tests must fail in this case, otherwise they do not prove that the changes to main fix or change anything. IOW, in TDD terms: Write and run the tests FIRST, see them fail, change the code in main, run the test again, if they now pass, all is well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
