[
https://issues.apache.org/jira/browse/POOL-402?focusedWorklogId=682398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682398
]
ASF GitHub Bot logged work on POOL-402:
---------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/21 06:25
Start Date: 17/Nov/21 06:25
Worklog Time Spent: 10m
Work Description: Cp-John commented on pull request #116:
URL: https://github.com/apache/commons-pool/pull/116#issuecomment-971231217
> Looks harmless and, as @psteitz pointed out, looks like it will improve
performance for some pools. Created placeholder issue, and looked at coverage.
>
>
>
> Even though it shows the line as covered, I believe not all branches of
the condition statement are covered. Not sure if it'd be easy to add a unit
test for when `getBlockWhenExhausted()` is `true` and when it's `false` (maybe
to avoid regressions)?
>
> Thanks Bruno
Hi Bruno! Thanks for your prompt response.
I have added two unit tests for when `getBlockWhenExhausted()` is `true` and
when it's `false`.
Cheers,
Cao Peng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682398)
Time Spent: 40m (was: 0.5h)
> Check blockWhenExhausted in hasBorrowWaiters
> --------------------------------------------
>
> Key: POOL-402
> URL: https://issues.apache.org/jira/browse/POOL-402
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 2.11.1
> Reporter: Bruno P. Kinoshita
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Placeholder for https://github.com/apache/commons-pool/pull/116
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
