[
https://issues.apache.org/jira/browse/POOL-402?focusedWorklogId=686957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686957
]
ASF GitHub Bot logged work on POOL-402:
---------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/21 06:01
Start Date: 27/Nov/21 06:01
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #116:
URL: https://github.com/apache/commons-pool/pull/116#issuecomment-980508876
Hi All.
I do not think this PR is ready yet because the tests pass when the `main`
changes are _not_ applied.
The new tests must fail in this case, otherwise they do not prove that the
changes to main fix or change anything.
IOW, in TDD terms: Write and run the tests FIRST, see them fail, change the
code in main, run the test again, if they now pass, all is well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686957)
Time Spent: 1h 10m (was: 1h)
> Check blockWhenExhausted in hasBorrowWaiters
> --------------------------------------------
>
> Key: POOL-402
> URL: https://issues.apache.org/jira/browse/POOL-402
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 2.11.1
> Reporter: Bruno P. Kinoshita
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Placeholder for https://github.com/apache/commons-pool/pull/116
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
