PostelnicuGeorge commented on a change in pull request #236:
URL: https://github.com/apache/commons-compress/pull/236#discussion_r774536136
##########
File path: src/main/java/org/apache/commons/compress/utils/FileNameUtils.java
##########
@@ -50,6 +51,19 @@ public static String getExtension(final String filename) {
return name.substring(extensionPosition + 1);
}
+ public static String getExtensionFrom(final Path path) {
Review comment:
My intention with these 2 methods getExtensionFrom and getBaseNameFrom
is to eventually replace getExtension and getBaseName, given the transition to
Paths, furthermore they can't be private/package-private due to their usage in
tests and in other packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
