PeterAlfredLee commented on a change in pull request #236:
URL: https://github.com/apache/commons-compress/pull/236#discussion_r774557487
##########
File path:
src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitOutputStream.java
##########
@@ -57,19 +58,31 @@
* @param zipFile the zip file to write to
* @param splitSize the split size
*/
- public ZipSplitOutputStream(final File zipFile, final long splitSize)
throws IllegalArgumentException, IOException {
+ public ZipSplitOutputStream(final Path zipFile, final long splitSize)
throws IllegalArgumentException, IOException {
if (splitSize < ZIP_SEGMENT_MIN_SIZE || splitSize >
ZIP_SEGMENT_MAX_SIZE) {
throw new IllegalArgumentException("zip split segment size should
between 64K and 4,294,967,295");
}
this.zipFile = zipFile;
this.splitSize = splitSize;
- this.outputStream = Files.newOutputStream(zipFile.toPath());
+ this.outputStream = Files.newOutputStream(zipFile);
// write the zip split signature 0x08074B50 to the zip file
writeZipSplitSignature();
}
+ /**
+ * Create a split zip. If the zip file is smaller than the split size,
+ * then there will only be one split zip, and its suffix is .zip,
+ * otherwise the split segments should be like .z01, .z02, ... .z(N-1),
.zip
+ *
+ * @param zipFile the zip file to write to
+ * @param splitSize the split size
+ */
Review comment:
Hi @PostelnicuGeorge
@garydgregory is talking about the `@since` tag. You can also find this in
comments of other methods.
1.21 is already released so you should add a `@since 1.22` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
