[GitHub] [commons-compress] garydgregory commented on a change in pull request #236: COMPRESS-602 - migrate zip package to nio path

[GitBox]

garydgregory commented on a change in pull request #236:
URL: https://github.com/apache/commons-compress/pull/236#discussion_r775047837



##########
File path: 
src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
##########
@@ -45,7 +46,8 @@ public void cleanup() {
     @Test
     public void putArchiveEntry() throws Exception {
         scatterFile = File.createTempFile("scattertest", ".notzip");
-        final ScatterZipOutputStream scatterZipOutputStream = 
ScatterZipOutputStream.fileBased(scatterFile);
+        final ScatterZipOutputStream scatterZipOutputStream = 
ScatterZipOutputStream.fileBased(scatterFile,
+                Deflater.BEST_COMPRESSION);
         final byte[] B_PAYLOAD = "RBBBBBBS".getBytes();

Review comment:
       Please keep the PR focused on one thing, this is a behavior change 
unrelated to NIO. May you revert this line please?

##########
File path: 
src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java
##########
@@ -45,7 +46,8 @@ public void cleanup() {
     @Test
     public void putArchiveEntry() throws Exception {
         scatterFile = File.createTempFile("scattertest", ".notzip");
-        final ScatterZipOutputStream scatterZipOutputStream = 
ScatterZipOutputStream.fileBased(scatterFile);
+        final ScatterZipOutputStream scatterZipOutputStream = 
ScatterZipOutputStream.fileBased(scatterFile,
+                Deflater.BEST_COMPRESSION);
         final byte[] B_PAYLOAD = "RBBBBBBS".getBytes();

Review comment:
       Please keep the PR focused on one thing, this is a behavior change 
unrelated to NIO. May you revert this line, please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org