cardamon edited a comment on pull request #71: URL: https://github.com/apache/commons-logging/pull/71#issuecomment-1005471886
~~OK, I'll see if I can think of some test.~~ Actually, I can't seem to think of something meaningful. There is actually an ignored test in which it is attempted to test something similar: https://github.com/apache/commons-logging/blob/94662842357bc38df6bbce5d144642b95a3e2dbd/src/test/java/org/apache/commons/logging/impl/WeakHashtableTestCase.java#L230 It is probably rightfully ignored because indeed `System.gc();` cannot be relied upon AFAIK. The `LogFactory` class is used in other tests however, and since it's about a static field / static init, will that do? If not, any suggestions @garydgregory @kinow ? Also, there might be a unrelated little bug I ran into when trying to run the tests: https://github.com/apache/commons-logging/blob/94662842357bc38df6bbce5d144642b95a3e2dbd/build-testing.xml#L103 That should probably be `1.2.1-SNAPSHOT` rather than `1.1.1-SNAPSHOT`. I think it's causing those `addLogicalLib("commons-logging");` calls on `PathableClassLoader` instances to not do what they are supposed to do... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
