cardamon commented on pull request #71:
URL: https://github.com/apache/commons-logging/pull/71#issuecomment-1006157362
Hmm but is really going to be an issue in practice?
The only situation that I can see in which some performance might be lost
(and I am admittedly not too familiar with the entire project and all its use
cases) is if `LogFactory.{createFactory,getFactory}` are called _after_ every
single hard reference to the class loader that loaded `LogFactory` is gone.
I would think that typically the class loader is pretty much the last thing
to go before an application is at the end at its lifecylce, containerized or
otherwise. So even if those factory methods are used in some shut down logic or
something like that, the class loader would still be there (ie. some hard ref
would still exist), and so the weak ref would still return it
(correct me if I'm wrong though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
