[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=705592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705592
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/22 10:22
Start Date: 08/Jan/22 10:22
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1007768801
@gwlucastrig , @darkma773r I believe this is ready for review again. And I
think it is really close to being ready to be merged! :tada:
@darkma773r I've removed the `Imaging` public methods that used
`ImagingParameter`'s (and `Hashmap`'s before). This reduced the amount of
public methods in `Imaging`, and later we can decide whether to add back
methods with Parameter factories/builders/mergers/etc, or create builders in
each parsers, or improve the parsers' API'...
After rebasing, there was a bit of Javadoc errors, probably from recent
plug-in versions. Fixed those too, reviewed the code removing unnecessary
changes, and finally added the `changes.xml` entry. With this, leaving the 126
modified files for you guys to review :smile: (sorry!)
Thanks a lot for the help,
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705592)
Time Spent: 18h (was: 17h 50m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 18h
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
