[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=709563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709563
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/22 21:18
Start Date: 15/Jan/22 21:18
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#discussion_r785353011
##########
File path: src/main/java/org/apache/commons/imaging/ImageParser.java
##########
@@ -955,18 +944,15 @@ protected BufferedImageFactory
getBufferedImageFactory(final Map<String, Object>
/**
* A utility method to search a params specification and determine
- * whether it contains the ImagingConstants.PARAM_KEY_STRICT
- * specification. Intended
+ * whether it contains the parameters contain the strict flag. Intended
* for internal use by ImageParser implementations.
*
- * @param params A valid Map object (or a null).
+ * @param params optional parameters.
* @return If the params specify strict format compliance, true;
* otherwise, false.
+ * @param <T> type of parameters used by this image parser
*/
- public static boolean isStrict(final Map<String, Object> params) {
- if (params == null ||
!params.containsKey(ImagingConstants.PARAM_KEY_STRICT)) {
- return false;
- }
- return ((Boolean)
params.get(ImagingConstants.PARAM_KEY_STRICT)).booleanValue();
+ public static <T extends ImagingParameters> boolean isStrict(final T
params) {
+ return params.isStrict();
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 709563)
Time Spent: 19h 10m (was: 19h)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
