garydgregory commented on code in PR #107:
URL:
https://github.com/apache/commons-configuration/pull/107#discussion_r873199983
##########
src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java:
##########
@@ -73,10 +73,13 @@ private static Date expectedDate() throws ParseException {
/**
* Create an instance of InternetAddress. This trick is necessary to
compile and run the test with Java 1.3 and the
- * javamail-1.4 which is not compatible with Java 1.3
+ * javamail-1.4 which is not compatible with Java 1.3.
+ *
+ * <p>javamail-2.0 had a namespace change, moving javax.mail.* to
jakarta.mail.*. This test verifies if we have
+ * javax.mail.* in the classpath before trying the Jakarta classes.</p>
*/
private Object createInternetAddress(final String email) throws Exception {
- final Class<?> cls =
Class.forName("javax.mail.internet.InternetAddress");
+ final Class<?> cls =
Class.forName("jakarta.mail.internet.InternetAddress");
Review Comment:
Let's resolve this one way or the other before we cut a release candidate...
@kinow any thoughts? As long we do not surface types from this dependency in
our public or protected APIs, we should be able to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
