garydgregory commented on code in PR #107:
URL:
https://github.com/apache/commons-configuration/pull/107#discussion_r878699404
##########
src/main/java/org/apache/commons/configuration2/convert/PropertyConverter.java:
##########
@@ -607,12 +612,22 @@ static Object toInternetAddress(final Object value)
throws ConversionException {
if (value.getClass().getName().equals(INTERNET_ADDRESS_CLASSNAME)) {
return value;
}
+ if
(value.getClass().getName().equals(INTERNET_ADDRESS_CLASSNAME_JAKARTA)) {
+ return value;
+ }
if (!(value instanceof String)) {
throw new ConversionException("The value " + value + " can't be
converted to a InternetAddress");
}
try {
- final Constructor<?> ctor =
Class.forName(INTERNET_ADDRESS_CLASSNAME).getConstructor(String.class);
- return ctor.newInstance(value);
+ try {
+ // javamail-2.0+, with jakarta.mail.* namespace.
+ final Constructor<?> ctor =
Class.forName(INTERNET_ADDRESS_CLASSNAME_JAKARTA).getConstructor(String.class);
+ return ctor.newInstance(value);
+ } catch (ClassNotFoundException e) {
+ // maybe javamail-1.*? With javax.mail.* namespace.
Review Comment:
I am not a fan of trying to support multiple versions of the same API here
or anywhere in the code base.
We support one jar or the other. This seems like the same issue @kinow
raised in
https://github.com/apache/commons-configuration/pull/107/files#r868840083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
