[
https://issues.apache.org/jira/browse/TEXT-216?focusedWorklogId=795622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795622
]
ASF GitHub Bot logged work on TEXT-216:
---------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 12:00
Start Date: 27/Jul/22 12:00
Worklog Time Spent: 10m
Work Description: darkma773r commented on PR #312:
URL: https://github.com/apache/commons-text/pull/312#issuecomment-1196636291
@rbunel35, thank you for the PR and apologies for the late reply.
This looks like useful functionality to me, although I'm slightly concerned
about the new size of `EntityArrays`. (If the character maps were accessed by
static methods instead of constants, I would recommend using separate private
classes to initialize each entity grouping.) Regardless, could you add a unit
test that iterates through each HTML5 entity in the official reference and
ensures that they are all accounted for and escaped/unescaped correctly? One
way to do this would be to convert the JSON reference document into a
properties file and load the properties file during the test.
Issue Time Tracking
-------------------
Worklog Id: (was: 795622)
Time Spent: 20m (was: 10m)
> HTML 5.0 Entities are not supported
> -----------------------------------
>
> Key: TEXT-216
> URL: https://issues.apache.org/jira/browse/TEXT-216
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Richard Bunel
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As noted in
> [TEXT-193|https://issues.apache.org/jira/projects/TEXT/issues/TEXT-193] and
> probably other tickets, HTML 5.0 entities are not supported.
> A nice evolution would be to include them all.
> Tentative PR: https://github.com/apache/commons-text/pull/312
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
