[
https://issues.apache.org/jira/browse/TEXT-216?focusedWorklogId=811687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811687
]
ASF GitHub Bot logged work on TEXT-216:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/22 19:12
Start Date: 23/Sep/22 19:12
Worklog Time Spent: 10m
Work Description: garydgregory commented on PR #312:
URL: https://github.com/apache/commons-text/pull/312#issuecomment-1256580580
> @rbunel35, thank you for the PR and apologies for the late reply.
>
> This looks like useful functionality to me, although I'm slightly
concerned about the new size of `EntityArrays`. (If the character maps were
accessed by static methods instead of constants, I would recommend using
separate private classes to initialize each entity grouping.) Regardless, could
you add a unit test that iterates through each HTML5 entity in the official
reference and ensures that they are all accounted for and escaped/unescaped
correctly? One way to do this would be to convert the JSON reference document
into a properties file and load the properties file during the test.
I agree about splitting out the large new arrays into a new class.
In general, new public and protected elements need to be documented with the
Javadoc since tag. Also, we should make as little as possible new or protected
to give us maximum flexibility for maintenance.
Issue Time Tracking
-------------------
Worklog Id: (was: 811687)
Time Spent: 0.5h (was: 20m)
> HTML 5.0 Entities are not supported
> -----------------------------------
>
> Key: TEXT-216
> URL: https://issues.apache.org/jira/browse/TEXT-216
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Richard Bunel
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As noted in
> [TEXT-193|https://issues.apache.org/jira/projects/TEXT/issues/TEXT-193] and
> probably other tickets, HTML 5.0 entities are not supported.
> A nice evolution would be to include them all.
> Tentative PR: https://github.com/apache/commons-text/pull/312
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
