garydgregory commented on PR #933: URL: https://github.com/apache/commons-lang/pull/933#issuecomment-1213539268
Hm, at first I thought this would be OK but now I'm not sure and would like community feedback: - There are APIs im the JRE called `isEmpty()` on various classes that usually return true when `size() == 0`; for example `Collection`, `String`, and `Map`. - There _isn't_ an `Optional` API called `isEmpty`, instead, there is a different concept represented by `isPresent()`; which returns true when the wrapped value is non-null. So it feels like this PR conflates the two concepts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
