garydgregory commented on PR #933: URL: https://github.com/apache/commons-lang/pull/933#issuecomment-1216461134
Hi All: The addition of Optional#isEmpty() in Java 11 seems to be an argument in favor of supporting Optional in our isEmpty() method, I think we need to consider if it makes sense, as opposed to just being doable. IOW, is a wrapper of a null value "empty"? Is a wrapper of an empty String empty? Is a wrapper of an empty Collection empty? Using recursion seems to be a recipe for confusion: Why recurse into one kind of object and not another? IOW, why recuse into Optional and not into Collections and Maps? What do others think? I do not think we need to consider an implementation vs. another until we can give answers and provide a consistent picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
