[
https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818577
]
ASF GitHub Bot logged work on CSV-302:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/22 18:53
Start Date: 19/Oct/22 18:53
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #276:
URL: https://github.com/apache/commons-csv/pull/276#issuecomment-1284439699
#
[Codecov](https://codecov.io/gh/apache/commons-csv/pull/276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#276](https://codecov.io/gh/apache/commons-csv/pull/276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9224a78) into
[master](https://codecov.io/gh/apache/commons-csv/commit/dc786a4cf5bc7968646d4e9d24f29b0fa626b71f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(dc786a4) will **decrease** coverage by `0.23%`.
> The diff coverage is `90.90%`.
```diff
@@ Coverage Diff @@
## master #276 +/- ##
============================================
- Coverage 97.35% 97.11% -0.24%
- Complexity 538 542 +4
============================================
Files 11 11
Lines 1171 1178 +7
Branches 204 206 +2
============================================
+ Hits 1140 1144 +4
- Misses 18 20 +2
- Partials 13 14 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-csv/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...rc/main/java/org/apache/commons/csv/CSVFormat.java](https://codecov.io/gh/apache/commons-csv/pull/276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVkZvcm1hdC5qYXZh)
| `96.71% <90.90%> (-0.47%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 818577)
Time Spent: 40m (was: 0.5h)
> CSVFormat.duplicateHeaderMode requires default for backward compatibility
> -------------------------------------------------------------------------
>
> Key: CSV-302
> URL: https://issues.apache.org/jira/browse/CSV-302
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
> Affects Versions: 1.10.0
> Reporter: Markus Spann
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The member in class {{CSVFormat}}
> {code:java}
> boolean allowDuplicateHeaderNames{code}
> was recently replaced by
> {code:java}
> DuplicateHeaderMode duplicateHeaderMode{code}
> The boolean defaults to {{{}false{}}}, while the member of type
> {{DuplicateHeaderMode}} defaults to {{{}null{}}}.
> {{duplicateHeaderMode}} must be initialized with {{DISALLOW}} for backward
> compatibility.
> The change is also problematic with regards to serialization. The class is
> serializable and {{serialVersionUID}} is unchanged between versions. The
> boolean setting {{allowDuplicateHeaderNames}} in an object serialized in
> version 1.9.0 or earlier would always be de-serialized to
> {{duplicateHeaderMode = null}} in the current head.
> To handle the code changes correctly, customized de-serialization would need
> to be implemented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
