[
https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818811
]
ASF GitHub Bot logged work on CSV-302:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/22 14:19
Start Date: 20/Oct/22 14:19
Worklog Time Spent: 10m
Work Description: garydgregory commented on PR #276:
URL: https://github.com/apache/commons-csv/pull/276#issuecomment-1285630822
Hi @sman-81
Shouldn't the `serialVersionUID` be updated since 1.10.0 adds
`duplicateHeaderMode`? Wouldn't this be simpler?
Issue Time Tracking
-------------------
Worklog Id: (was: 818811)
Time Spent: 2h (was: 1h 50m)
> CSVFormat.duplicateHeaderMode requires default for backward compatibility
> -------------------------------------------------------------------------
>
> Key: CSV-302
> URL: https://issues.apache.org/jira/browse/CSV-302
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
> Affects Versions: 1.x
> Reporter: Markus Spann
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The member in class {{CSVFormat}}
> {code:java}
> boolean allowDuplicateHeaderNames{code}
> was recently replaced by
> {code:java}
> DuplicateHeaderMode duplicateHeaderMode{code}
> The boolean defaults to {{{}false{}}}, while the member of type
> {{DuplicateHeaderMode}} defaults to {{{}null{}}}.
> {{duplicateHeaderMode}} must be initialized with {{DISALLOW}} for backward
> compatibility.
> The change is also problematic with regards to serialization. The class is
> serializable and {{serialVersionUID}} is unchanged between versions. The
> boolean setting {{allowDuplicateHeaderNames}} in an object serialized in
> version 1.9.0 or earlier would always be de-serialized to
> {{duplicateHeaderMode = null}} in the current head.
> To handle the code changes correctly, customized de-serialization would need
> to be implemented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
