[ 
https://issues.apache.org/jira/browse/MATH-1569?focusedWorklogId=819191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819191
 ]

ASF GitHub Bot logged work on MATH-1569:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/22 17:14
            Start Date: 21/Oct/22 17:14
    Worklog Time Spent: 10m 
      Work Description: aherbert commented on code in PR #219:
URL: https://github.com/apache/commons-math/pull/219#discussion_r1002016353


##########
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/dfp/Dfp.java:
##########
@@ -663,8 +663,8 @@ public Dfp getTwo() {
     /** Shift the mantissa left, and adjust the exponent to compensate.
      */
     protected void shiftLeft() {
-        for (int i = mant.length - 1; i > 0; i--) {
-            mant[i] = mant[i - 1];
+        if (mant.length - 1 >= 0) {

Review Comment:
   `> 0`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 819191)
    Time Spent: 1h 10m  (was: 1h)

> Manual array copy
> -----------------
>
>                 Key: MATH-1569
>                 URL: https://issues.apache.org/jira/browse/MATH-1569
>             Project: Commons Math
>          Issue Type: Sub-task
>            Reporter: Arturo Bernal
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to