[
https://issues.apache.org/jira/browse/MATH-1569?focusedWorklogId=819196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819196
]
ASF GitHub Bot logged work on MATH-1569:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/22 17:27
Start Date: 21/Oct/22 17:27
Worklog Time Spent: 10m
Work Description: aherbert commented on code in PR #219:
URL: https://github.com/apache/commons-math/pull/219#discussion_r1002028137
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/DSCompiler.java:
##########
@@ -1461,9 +1461,7 @@ public void cosh(final double[] operand, final int
operandOffset,
function[0] = JdkMath.cosh(operand[operandOffset]);
if (order > 0) {
function[1] = JdkMath.sinh(operand[operandOffset]);
- for (int i = 2; i <= order; ++i) {
Review Comment:
This is wrong
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/DSCompiler.java:
##########
@@ -1486,9 +1484,7 @@ public void sinh(final double[] operand, final int
operandOffset,
function[0] = JdkMath.sinh(operand[operandOffset]);
if (order > 0) {
function[1] = JdkMath.cosh(operand[operandOffset]);
- for (int i = 2; i <= order; ++i) {
Review Comment:
This is wrong
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/function/Logit.java:
##########
@@ -182,8 +182,8 @@ public DerivativeStructure value(final DerivativeStructure
t)
// for x close to hi the signs will always be +inf)
// this is probably overkill, since the call to compose at the end
// of the method will transform most infinities into NaN ...
- for (int i = 2; i < f.length; ++i) {
Review Comment:
This is wrong. f[0 and f[1] have been set and should be duplicated through
the array.
Issue Time Tracking
-------------------
Worklog Id: (was: 819196)
Time Spent: 1h 20m (was: 1h 10m)
> Manual array copy
> -----------------
>
> Key: MATH-1569
> URL: https://issues.apache.org/jira/browse/MATH-1569
> Project: Commons Math
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
