[
https://issues.apache.org/jira/browse/NET-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved NET-311.
----------------------
Resolution: Invalid
I think you have overlooked that the comparisons are != rather than ==.
The condition is possible to satisfy.
It is of the form:
mode != ACTIVE && mode != PASSIVE
which (by de Morgan) is the same as
NOT (mode == ACTIVE || mode == PASSIVE)
Consider what happens if the mode is neither ACTIVE nor PASSIVE.
> FTPClient.protected Socket _openDataConnection_(int command, String arg)
> returns null
> -------------------------------------------------------------------------------------
>
> Key: NET-311
> URL: https://issues.apache.org/jira/browse/NET-311
> Project: Commons Net
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Windows XP, but I would think not platform specific.
> Reporter: Brent W.
> Priority: Blocker
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> protected Socket _openDataConnection_(int command, String arg)
> throws IOException
> {
> Socket socket;
> if (__dataConnectionMode != ACTIVE_LOCAL_DATA_CONNECTION_MODE &&
> __dataConnectionMode != PASSIVE_LOCAL_DATA_CONNECTION_MODE)
> return null;
> ....
> }
> This if condition is impossible to satisfy. Should be OR(||) instead of
> AND(&&).
> __dataConnectionMode can not be set to 2 & 0 at the same time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
