rmannibucau commented on PR #248: URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354381686
+1 to get it in or switch now (I know it is a bit early and it is not justified to get 2 "main" branches). Note that if it helps adding a test is very feasible - we do at openwebbeans for ex - and enforcing binary compatiblity can be done too even if quite useless for this particular project (guess a test is a very good compromise since it will validate both at once). The only change I would do is to relocate `org.apache.commons.dbcp2` in `org.apache.commons.dbcp2.jakarta` to ensure both can run together - yes it happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
