rmannibucau commented on PR #248: URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354435743
> impossible to debug, and again, untested So factually you can debug as any artifact - you shade the sources too, it is used and got proven working fine by multiple asf projects. And test is just a matter of writing some test or re-executing the suite ones if you prefer (but technically/theorically speaking you need just a smoke test covering the javax integration code to ensure it works since functionally the rest is already covered). So overall both points are not blockers and are even almost not true. > the sanest way to do that is changing the source So it means jakarta is used on master, by commons rules it becomes dbcp3. So, as mentionned question is: do we abandon dbcp2 and consider javax is no more used. If so I join you but if not (and I think we still have 2-3 years of javax) then we should target to enable jakarta (dbcp2.jakarta package) and maintain a single code base - would be a pain for no gain at all to fork ourselves for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
