NaveenKunapaneni opened a new pull request, #291:
URL: https://github.com/apache/commons-imaging/pull/291
IcnsImageParser -> Refactored a complex method(writeImage) to multiple
smaller components (getImageType(src), writeHeader(bos, imageType),
writeImageData(bos, src, imageType), writeMaskData(bos, src, imageType),
PhotometricInterpreterLogLuv ->Introduced a new variable
expected_bit_per_sample,
ByteSourceArray -> Deomposed a complex contional if statement in getBlock
method,
PcxWriter -> Moved a method writePixel32 from PcxWriter to RleWriter class,
pivotProcessor -> Extracted methods which calculates pivot related values
and pushed them to a new class ,
ImageParser -> pushed down a method form the parent class (ImageParser) to
child ( PsdImageParser PngImageParser) classes.
I am currently studying on smells and various techniques to refactor
smells. This is a small effort on getting an under standing code smells and
refactoring them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
