kinow commented on code in PR #291:
URL: https://github.com/apache/commons-imaging/pull/291#discussion_r1159316289
##########
.idea/misc.xml:
##########
Review Comment:
Ide files are not included with imaging.
##########
src/main/java/org/apache/commons/imaging/color/ColorConversions.java:
##########
@@ -49,9 +43,9 @@ public static ColorCieLab convertXYZtoCIELab(final double X,
final double Y, fin
double var_Z = Z / REF_Z; // REF_Z = 108.883
// Pivot XÝZ:
- var_X = pivotXYZ(var_X);
- var_Y = pivotXYZ(var_Y);
- var_Z = pivotXYZ(var_Z);
+ var_X = pivotProcessor.pivotXYZ(var_X);
+ var_Y = pivotProcessor.pivotXYZ(var_Y);
+ var_Z = pivotProcessor.pivotXYZ(var_Z);
Review Comment:
Variables in Imaging may have weird names but these many times match what is
described on papers and specifications. Refactorings like these are not really
helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
