ivakegg commented on code in PR #395:
URL: https://github.com/apache/commons-vfs/pull/395#discussion_r1186844114
##########
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##########
@@ -263,14 +309,14 @@ public void rejectedExecution(Runnable r,
ThreadPoolExecutor executor) {
workQueue.addAll(rejected);
}
executor.shutdown();
- executor.awaitTermination(30, TimeUnit.SECONDS);
+ executor.awaitTermination(5, TimeUnit.MINUTES);
assertEquals(THREADS, executor.getCompletedTaskCount());
if (!exceptions.isEmpty()) {
StringBuilder exceptionMsg = new StringBuilder();
StringBuilderWriter writer = new StringBuilderWriter(exceptionMsg);
PrintWriter pWriter = new PrintWriter(writer);
for (Throwable t : exceptions) {
- pWriter.write(t.getMessage());
+ pWriter.write(String.valueOf(t.getMessage()));
Review Comment:
Because the message can be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
