ivakegg commented on code in PR #395:
URL: https://github.com/apache/commons-vfs/pull/395#discussion_r1189821287
##########
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##########
@@ -217,7 +249,17 @@ public void testSealing() throws Exception {
@Test
public void testThreadSafety() throws Exception {
- final int THREADS = 40;
+ final FileSystemManager manager = getManager();
+
+ // The http4 and sftp mechanisms do not work with this thread safety
test
+ List<String> schemes = Arrays.asList(manager.getSchemes());
+ if (schemes.contains("http4") || schemes.contains("sftp")) {
Review Comment:
Also it appears that the test infrastructure for the provider tests uses an
older version of JUnit in which the Assume mechanism is not in place. I guess
I need to go forward and see if I can fix those two protocols to work with that
test. I would like to leave it in the provider test suite to test all of the
others. An alternative is to add a mechanism in the test suite setup in which
certain test cases can be skipped.... may do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
