Ben-Waters commented on code in PR #189:
URL: https://github.com/apache/commons-codec/pull/189#discussion_r1243061478
##########
src/test/java/org/apache/commons/codec/language/NysiisTest.java:
##########
@@ -140,7 +140,8 @@ public void testDropBy() throws EncoderException {
new String[] { "JILES", "JAL" },
// violates 6: if the last two characters are AY, remove A
new String[] { "CARRAWAY", "CARY" }, // Original: CARAY
- new String[] { "YAMADA", "YANAD" });
+ new String[] { "YAMADA", "YANAD" },
+ new String[] { "ASH", "A"});
Review Comment:
It's pretty frustrating but it seems like the results are inconsistent
depending on where you go.
Looking at [this link](https://rosettacode.org/wiki/NYSIIS) the Java version
returns AS but the python returns A. For my use-case, either one of those would
be fine but it seems hard to get a consistent answer. Commons-codec is
currently returning nothing though and I haven't seen another do that yet.
I don't know of a good official implementation to run it against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
