garydgregory commented on code in PR #189:
URL: https://github.com/apache/commons-codec/pull/189#discussion_r1244281309
##########
src/test/java/org/apache/commons/codec/language/NysiisTest.java:
##########
@@ -140,7 +140,8 @@ public void testDropBy() throws EncoderException {
new String[] { "JILES", "JAL" },
// violates 6: if the last two characters are AY, remove A
new String[] { "CARRAWAY", "CARY" }, // Original: CARAY
- new String[] { "YAMADA", "YANAD" });
+ new String[] { "YAMADA", "YANAD" },
+ new String[] { "ASH", "A"});
Review Comment:
The question that comes up for me is: Is our current implementation "plain"
NYSIIS, or, is any non-standard or any behavior from the "modified" L&A 1977
algorithm present in our current implementation? If our current code is
"plain", then I could see us creating a `ModifiedNysiis` class, if not, then we
are in a bit of a pickle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
