garydgregory commented on code in PR #301:
URL: https://github.com/apache/commons-imaging/pull/301#discussion_r1257506692


##########
src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java:
##########
@@ -407,7 +407,7 @@ public byte[] getIccProfileBytes(final ByteSource 
byteSource, final GifImagingPa
     @Override
     public ImageInfo getImageInfo(final ByteSource byteSource, final 
GifImagingParameters params)
             throws ImagingException, IOException {
-        final GifImageContents blocks = readFile(byteSource, false);
+        final GifImageContents blocks = readFile(byteSource, true);

Review Comment:
   That's a good point!
   
   I wonder if this data is hard-coded to be skipped it will be unavailable for 
other API calls once the object is constructed. That would be bad. But if it 
can be paramerized, then the client call.site can decide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to