garydgregory commented on code in PR #301:
URL: https://github.com/apache/commons-imaging/pull/301#discussion_r1257659022
##########
src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java:
##########
@@ -407,7 +407,7 @@ public byte[] getIccProfileBytes(final ByteSource
byteSource, final GifImagingPa
@Override
public ImageInfo getImageInfo(final ByteSource byteSource, final
GifImagingParameters params)
throws ImagingException, IOException {
- final GifImageContents blocks = readFile(byteSource, false);
+ final GifImageContents blocks = readFile(byteSource, true);
Review Comment:
**Note**: All current callers of
`org.apache.commons.imaging.formats.gif.GifImageParser.readFile(ByteSource,
boolean)` pass false for `stopBeforeImageData`.
Would it make for all call sites to pick up this value from
`GifImagingParameters`? Or, would this cause some use-cases to break. We will
need to make sure to unit test whatever code we change or add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
