theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1370155220
########## src/main/java/org/apache/commons/text/cases/UpperCaseDelimitedCase.java: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +/** + * Case implementation which parses and formats strings where tokens are delimited by upper case characters. + */ +public class UpperCaseDelimitedCase implements Case { + + /** Flag to indicate whether the first character of the first token should be upper cased. */ + private boolean lowerCaseFirstCharacter = false; + + /** + * Constructs a new UpperCaseDelimitedCase instance. + */ + protected UpperCaseDelimitedCase(boolean lowerCaseFirstCharacter) { + this.lowerCaseFirstCharacter = lowerCaseFirstCharacter; + } + + /** + * Parses a string into tokens. + * <p> + * String characters are iterated over and when an upper case unicode character is + * encountered, that character is considered to be the start of a new token, with the character + * itself included in the token. This method will never return empty tokens. + * </p> + * @param string the string to parse + * @return the list of tokens found in the string + */ + @Override + public List<String> parse(String string) { + List<String> tokens = new ArrayList<>(); + if (string.length() == 0) { Review Comment: I agree. Handling null here is easy and doesn't really break anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
