elharo commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1377419333
########## src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; + +/** + * DelimitedCase is a case in which the true alphabetic case of the characters is ignored by default + * and tokens themselves are determined by the presence of a delimiter between each token. Review Comment: My concern is that for a string like foo-Bar-baz case is simply irrelevant. It's the tokens that delimit, but that's already handled by StringTokenizer in the JDK. Msybe what 's needed here is CaseTokenizer but drop CharacterDelimitedCase. Or maybe we need subclasses of StringTokenizer that tokenize based on case instead of delimiters? and then a couple of utility methods on top of that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
