garydgregory commented on PR #222: URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1825686434
> @arthurscchan Please use a better description in PRs and JIRA: Specify the class and method where the exception occurs. > > > Hi, I have added unit test. I am not sure about combining the PRs since they are opened as 4 different issues in the JIRA. > > > > > > In this case, I don't care about mapping PRs to JIRA 1-1. YMMV ;-) I care about making my life easier ;-) > > If you want, I don't mind combining all the PRs together, not sure if it is more messy to handle. Although they are throwing similar exceptions, I would say the reason is not too similar IMO. Well, at this point, I commented on all PRs, so we might as well leave it as is. You'll have to make sure to review all comments from all PRs as they apply to all PRs but I did not want to repeat myself all over the place ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
