arthurscchan commented on code in PR #222:
URL: https://github.com/apache/commons-codec/pull/222#discussion_r1412032098
##########
src/main/java/org/apache/commons/codec/net/PercentCodec.java:
##########
@@ -77,10 +77,15 @@ public PercentCodec() {
*
* @param alwaysEncodeChars the unsafe characters that should always be
encoded
* @param plusForSpace the flag defining if the space character
should be encoded as '+'
+ * @throws EncoderException if the alwaysEncodeChars byte array contains
invalid bytes
*/
- public PercentCodec(final byte[] alwaysEncodeChars, final boolean
plusForSpace) {
+ public PercentCodec(final byte[] alwaysEncodeChars, final boolean
plusForSpace) throws EncoderException {
Review Comment:
Yes, I think it is a better changes and interpretation of the exceptions. I
will change it accordingly.
@garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
