garydgregory commented on PR #1156: URL: https://github.com/apache/commons-lang/pull/1156#issuecomment-1913308295
Hi @theshoeshiner, @elharo, and all, I've spent some time reviewing this PR and comments and would like to offer up a compromise with PR https://github.com/apache/commons-lang/pull/1167: There is still a single proxy and it is much simpler to ignore thrown exceptions. I still do not like the idea having an additional proxy in the `EventListenerSupport` object. The PR #1167 maintains the 1-1-1 relationship of `EventListenerSupport`-to-`Proxy`-to-`InvocationHandler`. This does mean that you will need two `EventListenerSupport` instances to support fire-throws-exception and fire-does-not-throw-exception. The exception handing becomes customizable. This PR does not address the use case simply of gathering all exceptions thrown and throwing an exception after all listeners are caller. For this you would write, like today, your own `InvocationHandler`. In this use case, the thrown exception would either chain all exceptions thrown (a bit weird) or you'd create your own version of Commons IO's `IOExceptionList`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
