garydgregory commented on code in PR #92:
URL: https://github.com/apache/commons-beanutils/pull/92#discussion_r1474905048
##########
src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java:
##########
@@ -327,9 +329,21 @@ public String toString() {
thread.join();
assertEquals("Signal not set by test thread", 2, signal.getSignal());
- assertTrue("Different BeanUtilsBean instances per context
classloader", BeanUtilsBean.getInstance() != signal.getBean());
- assertTrue("Different ConvertUtilsBean instances per context
classloader", ConvertUtilsBean.getInstance() != signal.getConvertUtils());
- assertTrue("Different PropertyUtilsBean instances per context
classloader", PropertyUtilsBean.getInstance() != signal.getPropertyUtils());
+ assertNotEquals(
Review Comment:
What's the change here? If it's only formatting, please revert, it just
makes PRs noisier.
##########
src/main/java/org/apache/commons/beanutils2/sql/converters/SqlTimeConverter.java:
##########
@@ -62,12 +62,6 @@ protected Class<Time> getDefaultType() {
}
/**
- * Gets a {@code DateFormat} for the Locale.
Review Comment:
This seems to be going in the wrong direction. You want to fill in the TODO,
not blow away the whole Javadoc comment.
##########
src/main/java/org/apache/commons/beanutils2/sql/converters/SqlTimestampConverter.java:
##########
@@ -62,12 +62,6 @@ protected Class<Timestamp> getDefaultType() {
}
/**
- * Gets a {@code DateFormat} for the Locale.
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
