SethFalco commented on code in PR #92:
URL: https://github.com/apache/commons-beanutils/pull/92#discussion_r1474923351
##########
src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java:
##########
@@ -327,9 +329,21 @@ public String toString() {
thread.join();
assertEquals("Signal not set by test thread", 2, signal.getSignal());
- assertTrue("Different BeanUtilsBean instances per context
classloader", BeanUtilsBean.getInstance() != signal.getBean());
- assertTrue("Different ConvertUtilsBean instances per context
classloader", ConvertUtilsBean.getInstance() != signal.getConvertUtils());
- assertTrue("Different PropertyUtilsBean instances per context
classloader", PropertyUtilsBean.getInstance() != signal.getPropertyUtils());
+ assertNotEquals(
Review Comment:
Before: Used `assertTrue` with a condition to it.
After: Uses `assertNotEquals` with the 2 variables passed to it.
Typically, with JUnit `assertEquals` or `assertNotEquals` is used rather
than `==` or `!=`.
Happy to turn it back to a single line though, but the primary change was
the assertion method that was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
