garydgregory commented on PR #290: URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008164954
@PabloNicolasDiaz Thank you for your PR. I fixed a whole set of whitespace issues. 1. Please rebase on Git master to pick up a new version of our Checkstyle configuration, then 2. Run `mvn` by itself to run all build checks or `mvn checkstyle:check' to detect the remaining whitespace issues in this PR 3. Fix whatever the above detects then push your changes. Question: Does the new class `RecordComponentInfo` need to be public? The general idea is to make as little as possible public. Missing: All new public and protected items need Javadoc, and for some new items this PR is missing the first sentence in the Javadoc. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
