garydgregory commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008589150
@PabloNicolasDiaz
The PR still causes the build to fail.
Also, note that the code coverage is insufficient as reported by Codecov:
```
Attention: Patch coverage is 50.56180% with 44 lines in your changes are
missing coverage. Please review.
Project coverage is 65.09%. Comparing base (f32c53c) to head (ce967c6).
Report is 35 commits behind head on master.
Files Patch % Lines
...rc/main/java/org/apache/bcel/classfile/Record.java 53.84% 16
Missing and 2 partials ⚠️
...org/apache/bcel/classfile/RecordComponentInfo.java 55.55% 11
Missing and 1 partial ⚠️
...a/org/apache/bcel/classfile/DescendingVisitor.java 0.00% 8
Missing ⚠️
...main/java/org/apache/bcel/classfile/JavaClass.java 66.66% 2
Missing and 2 partials ⚠️
...c/main/java/org/apache/bcel/classfile/Visitor.java 0.00% 2
Missing ⚠️Additional details and impacted files
@@ Coverage Diff @@
## master #290 +/- ##
============================================
- Coverage 65.10% 65.09% -0.02%
- Complexity 3893 3909 +16
============================================
Files 364 366 +2
Lines 15657 15745 +88
Branches 1956 1967 +11
============================================
+ Hits 10194 10249 +55
- Misses 4549 4577 +28
- Partials 914 919 +5
```
You can also use JaCoCo locally with `mvn clean site -P jacoco` and open the
site in `target/site` where you'll find a nice and detailed HTML report; look
for JaCoCo in the left-hand side menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
