kinow commented on PR #359: URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2027422945
Reviewed #366, I think that one can be merged. That pull request fixes a `@Disabled` test that does the roud-trip test for EXIF data. Once that's merged, and the test is re-enabled, there is a test image in #366 that should fail. I think here we have to: 1. Wait for #366 to be merged 2. Use the test image to confirm the test fails for that image 3. Check out this branch, re-run the test with the new image 4. Review the license for that image, and if we really cannot use it, then decide what to do (I would spend some time checking if a similar image can be crafted or found somewhere else) 5. Once the image is added, confirm the code here is being covered by the test+new image, and approve and merge! :rocket: Cheers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
